Fokko commented on code in PR #1681:
URL: https://github.com/apache/iceberg-python/pull/1681#discussion_r1978898255
##########
pyiceberg/avro/reader.py:
##########
@@ -201,6 +201,15 @@ def skip(self, decoder: BinaryDecoder) -> None:
decoder.skip(16)
+class UnknownReader(Reader):
+ def read(self, decoder: BinaryDecoder) -> None:
+ _ = decoder.read_bytes()
+ return None
+
+ def skip(self, decoder: BinaryDecoder) -> None:
+ decoder.skip_bytes()
Review Comment:
I missed this one, this should be a no-op as well:
```suggestion
def read(self, decoder: BinaryDecoder) -> None:
return None
def skip(self, decoder: BinaryDecoder) -> None:
pass
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
