nastra commented on code in PR #12197:
URL: https://github.com/apache/iceberg/pull/12197#discussion_r1979704662
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -198,18 +167,33 @@ Map<String, String> params() {
}
public RESTSessionCatalog() {
- this(config ->
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI)).build(),
null);
+ this(
+ config -> {
+ HTTPClient.Builder builder =
+
HTTPClient.builder(config).uri(config.get(CatalogProperties.URI));
+ configHeaders(config).forEach(builder::withHeader);
+ return builder.build();
+ },
+ null);
}
public RESTSessionCatalog(
Function<Map<String, String>, RESTClient> clientBuilder,
BiFunction<SessionContext, Map<String, String>, FileIO> ioBuilder) {
+ this(clientBuilder, ioBuilder, AuthManagers::loadAuthManager);
+ }
+
+ public RESTSessionCatalog(
+ Function<Map<String, String>, RESTClient> clientBuilder,
+ BiFunction<SessionContext, Map<String, String>, FileIO> ioBuilder,
+ BiFunction<String, Map<String, String>, AuthManager> authManagerBuilder)
{
Review Comment:
I believe we exposed this mainly for Trino so that Trino is able to use
their own FileIO builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
