hsiang-c commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1982319469
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +561,120 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ this.crs = crs;
+ }
+
+ public static GeometryType get() {
+ return of("");
+ }
+
+ public static GeometryType of(String crs) {
+ return new GeometryType(crs == null ? "" : crs);
Review Comment:
(nit) Maybe `crs == null` can be `crs == null || crs.isEmpty()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
