Fokko commented on code in PR #317:
URL: https://github.com/apache/iceberg-go/pull/317#discussion_r1984821694
##########
manifest.go:
##########
@@ -1519,7 +1492,13 @@ func (f *fallbackManifestEntryV1) toEntry()
*manifestEntryV1 {
return &f.manifestEntryV1
}
-func (m *manifestEntryV1) inheritSeqNum(manifest ManifestFile) {}
+func (m *manifestEntryV1) inherit(manifest ManifestFile) {
+ if m.Snapshot <= 0 {
+ m.Snapshot = manifest.SnapshotID()
+ }
Review Comment:
For completeness, inheritance has been introduced in V2 to enable so called
fast-appends, but I believe the Java implementation allows this also for V1
tables by setting a specific feature flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
