liurenjie1024 commented on code in PR #907:
URL: https://github.com/apache/iceberg-rust/pull/907#discussion_r1986559287
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -509,6 +584,89 @@ impl ParquetWriter {
Ok(builder)
}
+
+ fn transverse_batch(&mut self, col: &ArrayRef, field: &NestedFieldRef) {
Review Comment:
This is only arrow related, I think it's better to move it to arrow module.
Also we have a good example of visiting arrow array along with iceberg schema,
see [this
part](https://github.com/apache/iceberg-rust/blob/ba71eea1e89a9a93ed10559af1c80a201b90b40a/crates/iceberg/src/arrow/value.rs#L544)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
