liurenjie1024 commented on code in PR #1034:
URL: https://github.com/apache/iceberg-rust/pull/1034#discussion_r1988854780
##########
crates/iceberg/src/transaction.rs:
##########
@@ -236,57 +240,59 @@ impl<'a> FastAppendAction<'a> {
self.add_data_files(data_files)?;
- self.apply().await
+ self.apply(check_duplicate).await
}
/// Finished building the action and apply it to the transaction.
- pub async fn apply(self) -> Result<Transaction<'a>> {
+ pub async fn apply(self, check_duplicate: bool) -> Result<Transaction<'a>>
{
Review Comment:
We should add an option in `FileAppendAction` rather in `apply` method,
since this approach can't be extended to more options.
```rust
struct FileAppendAction {
check_duplicate: bool
}
impl FileAppendAction {
pub fn check_duplicate(v: bool) -> Self {
this.check_duplicate = v;
self
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
