malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989921471
##########
pyiceberg/table/update/schema.py:
##########
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
field_type=field.field_type,
doc=field.doc,
required=required,
+ initial_default=field.initial_default,
)
def update_column(
Review Comment:
Should we also allow updating `write-default` since based on my
understanding of the spec, write-default can be changed through
schema-evolution
([ref](https://iceberg.apache.org/spec/#edge-interpolation-algorithm:~:text=The%20write%2Ddefault%20is%20initially%20set%20to%20the%20same%20value%20as%20initial%2Ddefault%20and%20can%20be%20changed%20through%20schema%20evolution.))?
##########
pyiceberg/table/update/schema.py:
##########
@@ -330,6 +354,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
field_type=updated.field_type,
doc=updated.doc,
required=required,
+ initial_default=updated.initial_default,
Review Comment:
Should we also look at `write-default` here?
##########
pyiceberg/table/update/schema.py:
##########
@@ -330,6 +354,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
field_type=updated.field_type,
doc=updated.doc,
required=required,
+ initial_default=updated.initial_default,
Review Comment:
Same comment for other places too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
