wypoon commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1990386780
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestSystemFunctionPushDownDQL.java:
##########
@@ -84,20 +84,24 @@ public void removeTables() {
@TestTemplate
public void testYearsFunctionOnUnpartitionedTable() {
createUnpartitionedTable(spark, tableName);
- testYearsFunction(false);
+ testYearsFunction(false, false);
+ testYearsFunction(false, true);
}
@TestTemplate
public void testYearsFunctionOnPartitionedTable() {
createPartitionedTable(spark, tableName, "years(ts)");
- testYearsFunction(true);
+ testYearsFunction(true, false);
+ testYearsFunction(true, true);
}
- private void testYearsFunction(boolean partitioned) {
+ private void testYearsFunction(boolean partitioned, boolean singular) {
Review Comment:
I adopted your recommendation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
