pvary commented on code in PR #12191:
URL: https://github.com/apache/iceberg/pull/12191#discussion_r1993382151
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -175,6 +178,18 @@ public Result applyFilters(List<ResolvedExpression>
flinkFilters) {
return Result.of(acceptedFilters, flinkFilters);
}
+ @Override
+ public void applySourceWatermark() {
+ if
(!readableConfig.get(FlinkConfigOptions.TABLE_EXEC_ICEBERG_USE_FLIP27_SOURCE)) {
Review Comment:
I would suggest to move to `Preconditions.checkArgument` - we usually stick
to that for this kind of checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
