bryanck commented on code in PR #12372:
URL: https://github.com/apache/iceberg/pull/12372#discussion_r1993730040
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##########
@@ -56,51 +71,65 @@ public int compare(TopicPartition o1, TopicPartition o2) {
}
}
- @Override
- public void start(Catalog catalog, IcebergSinkConfig config, SinkTaskContext
context) {
- KafkaClientFactory clientFactory = new
KafkaClientFactory(config.kafkaProps());
-
+ public boolean hasLeaderPartition(Collection<TopicPartition>
currentAssignedPartitions) {
Review Comment:
Also, nitpick, I feel we should remove `isLeader` and fold the logic in
here, having the two methods with similar names is somewhat confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
