rdblue commented on code in PR #12479:
URL: https://github.com/apache/iceberg/pull/12479#discussion_r1994241463
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -541,6 +547,10 @@ private void add(
}
private Iterable<CloseableIterable<ManifestEntry<DeleteFile>>>
deleteManifestReaders() {
+ if (ignoreResiduals) {
+ dataFilter = Expressions.alwaysTrue();
Review Comment:
If this is setting an instance field (which it appears to be) could you use
`this.` to make that more obvious?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
