rdblue commented on code in PR #12522:
URL: https://github.com/apache/iceberg/pull/12522#discussion_r1994355485
##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -67,24 +68,10 @@ public GenericManifestFile(Schema avroSchema) {
this.avroSchema = avroSchema;
}
- GenericManifestFile(InputFile file, int specId) {
- super(ManifestFile.schema().columns().size());
+ /** Used by Avro reflection to instantiate this class when reading manifest
files. */
Review Comment:
This is Iceberg reflection. Avro won't pass a `StructType` and uses an Avro
`Schema` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
