rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1994452758


##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -364,7 +365,11 @@ public void testUpdateFailure() {
             Types.FixedType.ofLength(4),
             Types.DecimalType.of(9, 2),
             Types.DecimalType.of(9, 3),
-            Types.DecimalType.of(18, 2));
+            Types.DecimalType.of(18, 2),
+            Types.GeometryType.get(),
+            Types.GeometryType.of("srid:3857"),
+            Types.GeographyType.get(),
+            Types.GeographyType.of("srid:4269", 
EdgeInterpolationAlgorithm.KARNEY));

Review Comment:
   Good catch with this test. @aihuaxu we will need to update this for variant 
and other types as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to