rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r1995894075
##########
api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java:
##########
@@ -63,7 +63,14 @@ public void testEqualTypes() throws Exception {
Types.DecimalType.of(9, 3),
Types.DecimalType.of(11, 0),
Types.FixedType.ofLength(4),
- Types.FixedType.ofLength(34)
+ Types.FixedType.ofLength(34),
+ Types.GeometryType.get(),
+ Types.GeometryType.of("srid:3857"),
+ Types.GeometryType.of("projjson:Test_Identifier"),
Review Comment:
Sorry, I meant is it valuable to have a `srid` case and a `projjson` case.
Both are strings and if we validate that any string is preserved by
serialization and deserialization, I think that is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
