ajantha-bhat commented on code in PR #12226:
URL: https://github.com/apache/iceberg/pull/12226#discussion_r1998445332
##########
core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java:
##########
@@ -103,7 +103,7 @@ public void testPartitionStats() throws Exception {
0,
0L,
0,
- 0L,
+ null,
Review Comment:
The current implementation doesn't compute it. Hence, it is always null
https://github.com/apache/iceberg/blob/57ec405a651b99d5fce3f3b4bec217d24bc98d20/core/src/main/java/org/apache/iceberg/PartitionStats.java#L124
Do you mean have a mock test, that sets `PartitionStats` with some number
for `total_record_count` (using StructLike's `set(pos, value)` and call
`get(pos, value)`? I think it is an overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
