danielcweeks commented on code in PR #10233:
URL: https://github.com/apache/iceberg/pull/10233#discussion_r1999657301
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -49,6 +62,11 @@ public class HadoopFileIO implements HadoopConfigurable,
DelegateFileIO {
private static final Logger LOG =
LoggerFactory.getLogger(HadoopFileIO.class);
private static final String DELETE_FILE_PARALLELISM =
"iceberg.hadoop.delete-file-parallelism";
+
+ /** Is bulk delete enabled on hadoop runtimes with API support: {@value}. */
+ public static final String BULK_DELETE_ENABLED =
"iceberg.hadoop.bulk.delete.enabled";
+
+ private static final boolean BULK_DELETE_ENABLED_DEFAULT = false;
Review Comment:
Is there a reason we wouldn't have this on by default? Is there a reason we
would even need this to be an option? If this is available in the linked
version of hadoop, I would prefer just removing the options and making it
always on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
