rdblue commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r488071443
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergDateObjectInspector.java
##########
@@ -42,17 +42,17 @@ private IcebergDateObjectInspector() {
@Override
public Date getPrimitiveJavaObject(Object o) {
- return o == null ? null : Date.valueOf((LocalDate) o);
+ return o == null ? null : Date.valueOf(o.toString());
}
@Override
- public DateWritable getPrimitiveWritableObject(Object o) {
- return o == null ? null : new
DateWritable(DateTimeUtil.daysFromDate((LocalDate) o));
+ public DateWritableV2 getPrimitiveWritableObject(Object o) {
+ return o == null ? null : new
DateWritableV2(DateTimeUtil.daysFromDate((LocalDate) o));
Review comment:
Can we control the type returned by the object inspector through a
config or by detecting whether `DateWritableV2` exists in the classpath? Then
we can use the same code for both 2.x and 3.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
