chenzl25 commented on code in PR #1077:
URL: https://github.com/apache/iceberg-rust/pull/1077#discussion_r2000091436
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -147,21 +147,21 @@ impl PopulatedDeleteFileIndex {
self.global_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
.filter(|&delete| {
seq_num
- .map(|seq_num| delete.manifest_entry.sequence_number() >=
Some(seq_num))
+ .map(|seq_num| delete.manifest_entry.sequence_number() >
Some(seq_num))
Review Comment:
Ok, I revert this line. However, if `global_deletes` is supposed to contain
all deletion files, I think we should use different sequence comparison to
treat with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
