mxm commented on code in PR #12527:
URL: https://github.com/apache/iceberg/pull/12527#discussion_r2000706468
##########
gradle.properties:
##########
@@ -16,8 +16,8 @@
jmhOutputPath=build/reports/jmh/human-readable-output.txt
jmhJsonOutputPath=build/reports/jmh/results.json
jmhIncludeRegex=.*
-systemProp.defaultFlinkVersions=1.20
-systemProp.knownFlinkVersions=1.18,1.19,1.20
+systemProp.defaultFlinkVersions=1.20,2.0
Review Comment:
I thought it could be helpful for devs to have two defaults. Which version
do you prefer to be active?
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -138,6 +141,12 @@ class IcebergFilesCommitter extends
AbstractStreamOperator<Void>
this.spec = spec;
}
+ @Override
+ protected void setup(
+ StreamTask<?, ?> containingTask, StreamConfig config,
Output<StreamRecord<Void>> output) {
+ super.setup(containingTask, config, output);
+ }
+
Review Comment:
I forgot to add a comment here, but the reason is the same as in
https://github.com/apache/iceberg/pull/12527/files/7eecf7fa428efbc7dd958d47e8cd74657d722541..35078bdc25647849afb06c58cdfbc5dda0c61830#diff-65fd76701c7646960de606de2cfe6ab6ba5f2eceb0ac66ca25ad321180127998R96
Changed.
##########
gradle/libs.versions.toml:
##########
@@ -45,6 +45,7 @@ findbugs-jsr305 = "3.0.2"
flink118 = { strictly = "1.18.1"}
flink119 = { strictly = "1.19.1"}
flink120 = { strictly = "1.20.0"}
+flink20 = { strictly = "2.0-preview1"}
Review Comment:
It has just been released. The artifacts are not yet distributed yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
