adutra commented on code in PR #12582:
URL: https://github.com/apache/iceberg/pull/12582#discussion_r2005026368
##########
aws/src/test/java/org/apache/iceberg/aws/TestRESTSigV4AuthManager.java:
##########
@@ -132,16 +131,16 @@ void catalogSession() {
@Test
void contextualSession() {
- AuthManager delegate = Mockito.mock(AuthManager.class);
- when(delegate.catalogSession(any(), any()))
- .thenReturn(Mockito.mock(OAuth2Util.AuthSession.class));
- when(delegate.contextualSession(any(), any()))
- .thenReturn(Mockito.mock(OAuth2Util.AuthSession.class));
+ AuthManager delegate =
Review Comment:
The tests failed to catch the issue because the delegate was a mock. I
replaced with an actual manager, and now the tests are properly exercising the
delegate, including the session cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
