amogh-jahagirdar commented on code in PR #12596:
URL: https://github.com/apache/iceberg/pull/12596#discussion_r2007885914
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
##########
@@ -94,12 +95,17 @@ public static Object[][] parameters() {
{FileFormat.PARQUET, true, 1},
{FileFormat.PARQUET, false, 2},
{FileFormat.PARQUET, true, 2},
+ {FileFormat.PARQUET, false, 3},
+ {FileFormat.PARQUET, true, 3},
Review Comment:
Adding these different combinations led to tests increasing in time from 20
to 25 seconds locally for me, so I figured it's worth having the coverage in V3
for each case since it doesn't come at too high a cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
