pvary commented on code in PR #12581:
URL: https://github.com/apache/iceberg/pull/12581#discussion_r2005681428
##########
orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriter.java:
##########
@@ -156,8 +156,8 @@ public Stream<FieldMetrics<?>> metrics() {
private static class RecordWriter extends
GenericOrcWriters.StructWriter<Record> {
- RecordWriter(List<OrcValueWriter<?>> writers) {
- super(writers);
+ RecordWriter(Types.StructType struct, List<OrcValueWriter<?>> writers) {
+ super(struct, writers);
Review Comment:
Do we need a similar change in Flink/Spark ORC writers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
