zhjwpku commented on code in PR #47:
URL: https://github.com/apache/iceberg-cpp/pull/47#discussion_r2010119246
##########
src/iceberg/type_fwd.h:
##########
@@ -81,4 +81,36 @@ class TimestampTzType;
class Type;
class UuidType;
+/// \brief Error types for iceberg.
+/// TODO: add more and sort them based on some rules.
+enum class ErrorKind {
+ kNoSuchNamespace,
+ kAlreadyExists,
+ kNoSuchTable,
+ kCommitStateUnknown,
+};
+
+struct Namespace;
Review Comment:
Since we are putting these forward declarations here, should we change the
name type_fwd.h to something like spec_fwd.h?
##########
src/iceberg/type_fwd.h:
##########
@@ -81,4 +81,36 @@ class TimestampTzType;
class Type;
class UuidType;
+/// \brief Error types for iceberg.
+/// TODO: add more and sort them based on some rules.
+enum class ErrorKind {
Review Comment:
Should we create a new file for this ErrorKind?
##########
.github/workflows/cpp-linter.yml:
##########
@@ -53,6 +53,7 @@ jobs:
thread-comments: true
ignore: 'build|cmake_modules|ci'
database: build
+ extra-args: '-I$PWD/src -I$PWD/build/src'
Review Comment:
Need rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
