adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2012849829
##########
core/src/test/java/org/apache/iceberg/rest/auth/TestBasicAuthManager.java:
##########
@@ -30,7 +30,7 @@ class TestBasicAuthManager {
@Test
void missingUsername() {
try (AuthManager authManager = new BasicAuthManager("test")) {
- assertThatThrownBy(() -> authManager.catalogSession(null, Map.of()))
+ assertThatThrownBy(() ->
authManager.authSession(ImmutableAuthScopes.Standalone.of(Map.of())))
Review Comment:
Mostly, yes. I tried to find a name that would capture its "generic" purpose
better than just calling it `Catalog` or `Table`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
