RussellSpitzer commented on code in PR #12493:
URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014994662
##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java:
##########
@@ -49,15 +56,15 @@ public abstract class SizeBasedDataRewriter extends
SizeBasedFileRewriter<FileSc
public static final int DELETE_FILE_THRESHOLD_DEFAULT = Integer.MAX_VALUE;
/**
- * The minimum deletion ratio that needs to be associated with a data file
for it to be considered
- * for rewriting. If the deletion ratio of a data file is greater than or
equal to this value, it
- * will be rewritten regardless of its file size determined by {@link
#MIN_FILE_SIZE_BYTES} and
- * {@link #MAX_FILE_SIZE_BYTES}. If a file group contains a file that
satisfies this condition,
- * the file group will be rewritten regardless of the number of files in the
file group determined
- * by {@link #MIN_INPUT_FILES}.
+ * The percentage of the deleted records in a data file that enforces a data
file rewrite. If the
+ * deletion ratio of a data file is greater or equal than this value, it
will be rewritten
+ * regardless of its file size determined by {@link #MIN_FILE_SIZE_BYTES}
and {@link
+ * #MAX_FILE_SIZE_BYTES}. If a file group contains a file that satisfies
this condition, the file
+ * group will be rewritten regardless of the number of files in the file
group determined by
+ * {@link #MIN_INPUT_FILES}.
*
- * <p>Defaults to 0.3, which means that if the deletion ratio of a file
reaches or exceeds 30%, it
- * may trigger the rewriting operation.
+ * <p>Defaults to 0.3, which means that if the number of deleted records in
a file reaches or
+ * exceeds 30%, it may trigger the rewriting operation.
Review Comment:
```suggestion
* exceeds 30%, it will trigger the rewriting operation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
