nastra commented on code in PR #12595:
URL: https://github.com/apache/iceberg/pull/12595#discussion_r2015851007
##########
core/src/main/java/org/apache/iceberg/rest/RESTUtil.java:
##########
@@ -38,6 +40,12 @@ public class RESTUtil {
private static final Joiner NAMESPACE_ESCAPED_JOINER =
Joiner.on(NAMESPACE_ESCAPED_SEPARATOR);
private static final Splitter NAMESPACE_ESCAPED_SPLITTER =
Splitter.on(NAMESPACE_ESCAPED_SEPARATOR);
+ public static final Function<Map<String, String>, RESTClient>
DEFAULT_CLIENT_BUILDER =
Review Comment:
this shouldn't be necessary. Can you please revert the refactorings from
1536b7f7e6276a15527a5fec6bb16ec0f47544b5 and only add the new tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
