steveloughran commented on code in PR #12264:
URL: https://github.com/apache/iceberg/pull/12264#discussion_r2007345417
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -275,6 +275,7 @@ private List<String> deleteBatch(String bucket,
Collection<String> keysToDelete)
DeleteObjectsRequest.builder()
.bucket(bucket)
.delete(Delete.builder().objects(objectIds).build())
+
.overrideConfiguration(S3RequestUtil.disableStrongIntegrityChecksums())
Review Comment:
I think they're slightly different checksums; there's always been md5 in
places (bulk delete?) ; AWS S3 and this SDK have moved to a stronger checksum
algorithm. When that is disabled you still need to restore the MD5 signing
where retired.
It may be best to move to an enum here, e.g. "none, classic, strong" to cope
with any future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
