andyglow commented on code in PR #12418:
URL: https://github.com/apache/iceberg/pull/12418#discussion_r2019836325
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -210,7 +210,12 @@ private Dataset<Row> removeCarryoverRows(Dataset<Row> df,
boolean netChanges) {
}
Column[] repartitionSpec =
-
Arrays.stream(df.columns()).filter(columnsToKeep).map(df::col).toArray(Column[]::new);
+ Arrays.stream(df.columns())
+ .filter(columnsToKeep)
+ .map(CreateChangelogViewProcedure::delimitedName)
+ .map(df::col)
+ .toArray(Column[]::new);
Review Comment:
good question, @flyrain
`delimitedName()` is already partially used in `identifierColumns()` method,
in it's part where columns are inferred from spark table definition. while we
take user defined (via `identifier_columns` parameter) column names as is. It's
left up to user to delimit names or not. I don't think we should forcefully
turn user defined column names into delimited ones. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
