wypoon commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2020290971
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -303,10 +303,10 @@ public void testThriftExceptionConcurrentCommit() throws
TException, Interrupted
@Test
public void testInvalidObjectException() {
- TableIdentifier badTi = TableIdentifier.of(DB_NAME, "`tbl`");
+ TableIdentifier badTi = TableIdentifier.of(DB_NAME, "tábl");
Review Comment:
Before Hive 4, the only special character allowed is '/':
https://github.com/apache/hive/blob/branch-3.1/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java#L155
```
private static final char[] specialCharactersInTableNames = new char[] {
'/' };
```
In Hive 4, all non-alphanumeric characters in a US keyboard, including
backtick ('`'), are allowed special characters:
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java#L175-L181
```
private static final char[] SPECIAL_CHARACTERS_IN_TABLE_NAMES = new char[]
{
// standard
' ', '"', '%', '&', '\'', '(', ')', '*', '+', ',', '-', '.', '/', ':',
';', '<', '=', '>', '?', '[', ']',
'_', '|', '{', '}', '$', '^',
// non-standard
'!', '~', '#', '@', '`'
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
