xiaoxuandev commented on code in PR #12551:
URL: https://github.com/apache/iceberg/pull/12551#discussion_r2021738899
##########
aws/src/test/java/org/apache/iceberg/aws/glue/TestIcebergToGlueConverter.java:
##########
@@ -384,4 +384,71 @@ public void
testSetTableInputInformationWithExistingTable() {
.as("Columns should match")
.isEqualTo(expectedTableInput.storageDescriptor().columns());
}
+
+ @Test
+ public void
testSetTableInputInformationWithExistingTableWithoutStorageDescriptor() {
Review Comment:
Can please use
[updateTableColumns](https://github.com/apache/iceberg/blob/12737a1282d2e82432c0e5924b3fe33dc4ffb109/aws/src/integration/java/org/apache/iceberg/aws/glue/GlueTestBase.java#L161)
for the test?
##########
aws/src/test/java/org/apache/iceberg/aws/glue/TestIcebergToGlueConverter.java:
##########
@@ -384,4 +384,71 @@ public void
testSetTableInputInformationWithExistingTable() {
.as("Columns should match")
.isEqualTo(expectedTableInput.storageDescriptor().columns());
}
+
+ @Test
+ public void
testSetTableInputInformationWithExistingTableWithoutStorageDescriptor() {
Review Comment:
Can we please use
[updateTableColumns](https://github.com/apache/iceberg/blob/12737a1282d2e82432c0e5924b3fe33dc4ffb109/aws/src/integration/java/org/apache/iceberg/aws/glue/GlueTestBase.java#L161)
for the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
