ZENOTME commented on code in PR #1154:
URL: https://github.com/apache/iceberg-rust/pull/1154#discussion_r2024859346
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -127,12 +127,14 @@ impl<'a> Transaction<'a> {
}
/// Creates a fast append action.
- pub fn fast_append(
+ pub async fn fast_append(
Review Comment:
According to iceberg-java, looks like we don't need to refresh here. The
lifecycle of a transaction looks like this:
- create transaction and get current table
- apply action to current table
- apply action to current table
- commit transaction
- refresh and get the latest table, see:
https://github.com/apache/iceberg/blob/c661a71091e496393c743ddd879d9e1a0f2747b2/core/src/main/java/org/apache/iceberg/BaseTransaction.java#L503
- reapply all update before and commit to catalog
I think can delay this part after #949. cc @Fokko @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
