danielcweeks commented on code in PR #12655:
URL: https://github.com/apache/iceberg/pull/12655#discussion_r2025176480
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -65,7 +68,14 @@ public RESTCatalog(Function<Map<String, String>, RESTClient>
clientBuilder) {
public RESTCatalog(
SessionCatalog.SessionContext context,
Function<Map<String, String>, RESTClient> clientBuilder) {
- this.sessionCatalog = new RESTSessionCatalog(clientBuilder, null);
+ this(context, clientBuilder, AuthManagers::loadAuthManager);
+ }
+
+ public RESTCatalog(
+ SessionCatalog.SessionContext context,
+ Function<Map<String, String>, RESTClient> clientBuilder,
+ BiFunction<String, Map<String, String>, AuthManager> authManagerBuilder)
{
Review Comment:
I guess this raises an interesting issue for how this is actually going to
be used. If you're planning on passing in an AuthManager that's shared, why do
we need a builder at all? Wouldn't it already be built and therefore a
reference would be sufficient?
However, the AuthManager will be used to go through the init session and
create the catalog session, so I'm not clear on what we expect that flow to
look like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
