Fokko commented on code in PR #1879:
URL: https://github.com/apache/iceberg-python/pull/1879#discussion_r2027379456
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -236,7 +236,6 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
return update_snapshot_summaries(
summary=Summary(operation=self._operation, **ssc.build(),
**snapshot_properties),
previous_summary=previous_snapshot.summary if previous_snapshot is
not None else None,
- truncate_full_table=self._operation == Operation.OVERWRITE,
Review Comment:
Good one! We have a test here:
https://github.com/apache/iceberg-python/blob/4d4714a46241d0d89519a2a605dbce27b713a60e/tests/integration/test_writes/test_writes.py#L253-L264
Let me double-check with Spark, because I think we should also include the
files that are dropped 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
