SanjayMarreddi commented on code in PR #12553:
URL: https://github.com/apache/iceberg/pull/12553#discussion_r2021575246
##########
aws-bundle/build.gradle:
##########
@@ -25,8 +25,11 @@ project(":iceberg-aws-bundle") {
dependencies {
implementation platform(libs.awssdk.bom)
+ implementation libs.awssdk.s3accessgrants
+ implementation libs.awssdk.crt
Review Comment:
- CRT is needed to make use of the `analytics-accelerator-s3` library
integration as the library itself won't include CRT in its JAR. So, I added
`libs.awssdk.crt` earlier. But after your comment, I realised that we already
have `software.amazon.awssdk:http-auth-aws-crt` which is sufficient too. So
including `libs.awssdk.crt` is not compulsory. Removed it now.
- `libs.awssdk.s3accessgrants` and `software.amazon.awssdk:crt-core` are
being used earlier also but not present in `aws-bundle`. We have decided to add
missing dependencies too when I do a follow-up PR
[here](https://github.com/apache/iceberg/pull/12299#discussion_r1989985092). I
thought we should make `aws-bundle` include all necessary AWS vendor
dependencies for user to have the best experience.
Please let me know if you have any questions/suggestions..
##########
gradle/libs.versions.toml:
##########
@@ -97,6 +98,7 @@ arrow-vector = { module = "org.apache.arrow:arrow-vector",
version.ref = "arrow"
avro-avro = { module = "org.apache.avro:avro", version.ref = "avro" }
awssdk-bom = { module = "software.amazon.awssdk:bom", version.ref =
"awssdk-bom" }
awssdk-s3accessgrants = { module =
"software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin", version.ref
= "awssdk-s3accessgrants" }
+awssdk-crt = { module = "software.amazon.awssdk.crt:aws-crt", version.ref =
"awssdk-crt" }
Review Comment:
I've addressed this above and removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
