manuzhang commented on code in PR #12681:
URL: https://github.com/apache/iceberg/pull/12681#discussion_r2030387861
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java:
##########
@@ -132,7 +131,7 @@ public <R> R run(Action<R, IMetaStoreClient, TException>
action, boolean retry)
static Key extractKey(String cacheKeys, Configuration conf) {
// generate key elements in a certain order, so that the Key instances are
comparable
List<Object> elements = Lists.newArrayList();
- elements.add(conf.get(HiveConf.ConfVars.METASTOREURIS.varname, ""));
+ elements.add(conf.get("hive.metastore.uris", ""));
Review Comment:
It might be better to define this constant in an Iceberg util class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
