nastra commented on code in PR #12595:
URL: https://github.com/apache/iceberg/pull/12595#discussion_r2036052912
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -121,9 +122,19 @@ public void createCatalog() throws Exception {
ImmutableMap.of(CatalogProperties.WAREHOUSE_LOCATION,
warehouse.getAbsolutePath()));
HTTPHeaders catalogHeaders =
- HTTPHeaders.of(Map.of("Authorization", "Bearer
client-credentials-token:sub=catalog"));
+ HTTPHeaders.of(
Review Comment:
no worries @adutra, it's actually my fault and I should have probably more
clear here. My main intention here was to avoid confusion for other readers of
the code as the existence of `X-Iceberg-Access-Delegation` might indicate that
the tests run with access delegation, while in fact we're just wanting to test
that the header is properly passed. I'm completely fine keeping/verifying the
header here and below but we should rename it to `test-header`/ `test-value` to
indicate that and avoid confusion.
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -194,7 +209,9 @@ protected RESTCatalog initCatalog(String catalogName,
Map<String, String> additi
CatalogProperties.TABLE_OVERRIDE_PREFIX + "override-key4",
"catalog-override-key4",
"credential",
- "catalog:12345");
+ "catalog:12345",
+ "header.X-Iceberg-Access-Delegation",
+ "vended-credentials");
Review Comment:
same as above, these changes here aren't really needed for the test to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
