chenjunjiedada commented on a change in pull request #1254:
URL: https://github.com/apache/iceberg/pull/1254#discussion_r491243920
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java
##########
@@ -85,6 +87,10 @@
this.rowGroups = reader.getRowGroups();
this.shouldSkip = new boolean[rowGroups.size()];
+ // Fetch all row groups starting positions to compute the row offsets of
the filtered row groups
+ Map<Long, Long> offsetToStartPos = generateOffsetToStartPos();
Review comment:
@sudssf , Yes, I have a PR: https://github.com/apache/iceberg/pull/1356.
It reads the file when the required schema contains position column.
```java
if (expectedSchema.findField(MetadataColumns.ROW_POSITION.fieldId()) !=
null) {
// Only read footer when needed
offsetToStartPos = generateOffsetToStartPos();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
