geruh commented on code in PR #12758:
URL: https://github.com/apache/iceberg/pull/12758#discussion_r2038467128
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -56,6 +58,57 @@ public void testLoadDefault() {
.isInstanceOf(AwsClientFactories.DefaultAwsClientFactory.class);
}
+ @Test
+ public void testS3AsyncClientCrtEnabled() {
+ assertThat(
+ AwsClientFactories.from(
+ ImmutableMap.of(
+ S3FileIOProperties.ACCESS_KEY_ID,
+ "keyId",
+ S3FileIOProperties.SECRET_ACCESS_KEY,
+ "accessKey",
+ S3FileIOProperties.S3_CRT_ENABLED,
+ "true",
+ AwsClientProperties.CLIENT_REGION,
+ "us-east-1"))
+ .s3Async())
+ .isInstanceOf(DefaultS3CrtAsyncClient.class);
+ }
+
+ @Test
+ public void testS3AsyncClientWithCrtDisabled() {
+ assertThat(
+ AwsClientFactories.from(
+ ImmutableMap.of(
+ S3FileIOProperties.ACCESS_KEY_ID,
+ "keyId",
+ S3FileIOProperties.SECRET_ACCESS_KEY,
+ "accessKey",
+ S3FileIOProperties.S3_CRT_ENABLED,
+ "false",
+ AwsClientProperties.CLIENT_REGION,
+ "us-east-1"))
+ .s3Async()
+ .getClass()
+ .getName())
+ .isEqualTo("software.amazon.awssdk.services.s3.DefaultS3AsyncClient");
Review Comment:
What do you think about referencing the async subclass `S3CrtAsyncClient`
for the CRT logic instead, and tack on the not instance of CRT for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
