Fokko commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2042524703
##########
format/spec.md:
##########
@@ -1414,12 +1414,16 @@ Each partition field in `fields` is stored as a JSON
object with the following p
| V1 | V2 | V3 | Field | JSON representation |
Example |
|----------|----------|----------|------------------|---------------------|--------------|
-| required | required | omitted | **`source-id`** | `JSON int` | 1
|
Review Comment:
> 2.1. We write always source-ids (source-id doesn't exist anymore on new
writer)
I had a similar question below. Would this also be true for `TableVersion≤2`?
> 1. For partition fields with a transform with a single argument, only
`source-id` is written. In case of a multi-argument transform, only
`source-ids` is written.
Initially, there was confusion around making both fields required, and this
was not incorrect. They are optional based on the number of arguments, and this
is fully deterministic. It would still follow @jbonofre's reader workflow, but
only produce one field based on the number of arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
