kumarpritam863 commented on code in PR #12460:
URL: https://github.com/apache/iceberg/pull/12460#discussion_r2044856578
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##########
@@ -18,11 +18,32 @@
*/
package org.apache.iceberg.connect;
-import org.apache.iceberg.connect.channel.CommitterImpl;
+import org.apache.iceberg.common.DynConstructors;
class CommitterFactory {
static Committer createCommitter(IcebergSinkConfig config) {
- return new CommitterImpl();
+ String committerImpl = config.committerImpl();
+ DynConstructors.Ctor<Committer> ctor;
+ try {
Review Comment:
I actually added these in different try blocks to differentiate between
failures to give user more clarity what actually failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
