amogh-jahagirdar commented on code in PR #12736:
URL: https://github.com/apache/iceberg/pull/12736#discussion_r2048093293
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaOperation.java:
##########
@@ -98,6 +99,12 @@ public DeltaWriteBuilder newWriteBuilder(LogicalWriteInfo
info) {
public NamedReference[] requiredMetadataAttributes() {
NamedReference specId = Expressions.column(MetadataColumns.SPEC_ID.name());
NamedReference partition =
Expressions.column(MetadataColumns.PARTITION_COLUMN_NAME);
+ if (TableUtil.formatVersion(table) >= 3) {
Review Comment:
instead of >= 3, maybe we want to move this to table util as well
TableUtil.supportsRowLineage. It avoids the "magic format" number that's
littered throughout now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
