sririshindra commented on code in PR #12824:
URL: https://github.com/apache/iceberg/pull/12824#discussion_r2049351617
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -2028,6 +2028,42 @@ protected List<DataFile> currentDataFiles(Table table) {
.collect(Collectors.toList());
}
+ @TestTemplate
+ public void testRewriteMaxFilesOption() {
Review Comment:
@coderfender
The test seems to actually fail when I run it on my laptop. Here the error
that I am seeing. As soon as I revert your commit I am not seeing the error. In
fact all the tests in the suites are failing with your commit for me. Not sure,
if this is a problem with the environment in my laptop or something missing
with your code. I haven't digged deep into it yet. I will do a more thorough
review as soon as I get a chance.
```
Cannot downgrade v3 table to v2
java.lang.IllegalArgumentException: Cannot downgrade v3 table to v2
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:301)
at
org.apache.iceberg.TableMetadata$Builder.upgradeFormatVersion(TableMetadata.java:1070)
at
org.apache.iceberg.TableMetadata.replaceProperties(TableMetadata.java:632)
at
org.apache.iceberg.PropertiesUpdate.lambda$commit$0(PropertiesUpdate.java:113)
at
org.apache.iceberg.util.Tasks$Builder.runTaskWithRetry(Tasks.java:413)
at
org.apache.iceberg.util.Tasks$Builder.runSingleThreaded(Tasks.java:219)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:203)
at org.apache.iceberg.util.Tasks$Builder.run(Tasks.java:196)
at org.apache.iceberg.PropertiesUpdate.commit(PropertiesUpdate.java:110)
at
org.apache.iceberg.spark.actions.TestRewriteDataFilesAction.testRewriteMaxFilesOption(TestRewriteDataFilesAction.java:2038)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at java.base/java.util.Optional.ifPresent(Optional.java:183)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
at
java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
at
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
at
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
