guptaakashdeep commented on code in PR #1936:
URL: https://github.com/apache/iceberg-python/pull/1936#discussion_r2051557551
##########
pyiceberg/transforms.py:
##########
@@ -111,29 +111,6 @@ def _transform_literal(func: Callable[[L], L], lit:
Literal[L]) -> Literal[L]:
return literal(func(lit.value))
-def parse_transform(v: Any) -> Any:
Review Comment:
@kevinjqliu yes this is intentional.
I had to re-position the `parse_transform` method to change the return type
of the method from Any to Transform[Any, Any] because mypy wasn't happy after
we made Transform type as `Union[str, Transform]` in `add_field`. Without
moving it down, Transform wasn't being recognized in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
