ZENOTME commented on code in PR #949:
URL: https://github.com/apache/iceberg-rust/pull/949#discussion_r2052452699
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -37,7 +38,8 @@ use crate::{Catalog, Error, ErrorKind, TableCommit,
TableRequirement, TableUpdat
/// Table transaction.
pub struct Transaction<'a> {
- table: &'a Table,
+ base_table: &'a Table,
+ current_table: Table,
Review Comment:
Some info is getting using the table directly, e.g.
https://github.com/apache/iceberg-rust/blob/e264f948a083fc080026285658a6a8cce6b4e781/crates/iceberg/src/transaction/append.rs#L121
So we have to save as the Table. But looks like MetadataTable only use
TableMetadata in Table. I think we can refactor it and save TableMetadata after
refactor. Seems this will not change the interface, we can do it after this PR
as a refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
