tedyu commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r2053022552
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -212,4 +220,13 @@ public void deletePrefix(String prefix) {
}
}
}
+
+ @Override
+ public void close() {
+ if (vendedAdlsCredentialProvider != null) {
+ vendedAdlsCredentialProvider.close();
+ }
+
+ DelegateFileIO.super.close();
Review Comment:
Should this be enclosed in finally block so that it is always run ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
