rdblue commented on pull request #1489: URL: https://github.com/apache/iceberg/pull/1489#issuecomment-698055822
@RussellSpitzer, we did careful validation to make sure the use of intern would be okay here. We want to complete as much as possible without running out of memory, so it works to use the weak key map and intern. And using identity instead of equality is fairly common when using weak keys. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
