pvary commented on a change in pull request #1481:
URL: https://github.com/apache/iceberg/pull/1481#discussion_r494196387



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -278,84 +268,6 @@ private Transaction newReplaceTableTransaction(boolean 
orCreate) {
     }
   }
 
-  /**
-   * Drops all data and metadata files referenced by TableMetadata.
-   * <p>
-   * This should be called by dropTable implementations to clean up table 
files once the table has been dropped in the
-   * metastore.
-   *
-   * @param io a FileIO to use for deletes
-   * @param metadata the last valid TableMetadata instance for a dropped table.
-   */
-  protected static void dropTableData(FileIO io, TableMetadata metadata) {

Review comment:
       Good point!
   Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to