dentiny commented on code in PR #1273:
URL: https://github.com/apache/iceberg-rust/pull/1273#discussion_r2065294379
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -68,6 +68,10 @@ pub trait Catalog: Debug + Sync + Send {
) -> Result<()>;
/// Drop a namespace from the catalog, or returns error if it doesn't
exist.
+ ///
+ /// If a parent namespace gets dropped, all its children namespaces will
be dropped as well.
+ /// This function doesn't provide transaction guarantee, which means it's
possible to have parent namespace deleted with children namespaces still left.
Review Comment:
For transaction guarantee, I'm thinking about object storage based catalog,
which could require list + multiple delete operations (depending on the
detailed implementation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
