RussellSpitzer commented on a change in pull request #1473:
URL: https://github.com/apache/iceberg/pull/1473#discussion_r494440447
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -250,7 +250,6 @@
<property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL,
GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS,
QUESTION, SL, SR, STAR "/>
</module>
<module name="OuterTypeFilename"/> <!-- Java Style Guide: File name -->
- <module name="OverloadMethodsDeclarationOrder"/> <!-- Java Style
Guide: Overloads: never split -->
Review comment:
I never really understood this rule :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
