JingsongLi commented on pull request #1346: URL: https://github.com/apache/iceberg/pull/1346#issuecomment-698682917
Thanks @rdblue for the review, I'll address your test comments in next PR (Integrate to SQL). The reason for a separate `ScanOptions` is: For SQL layer, `ScanOptions` contains options in `CREATE TABLE ... WITH (options)`, while other parameters of `FlinkSource.Builder` are not. This means that the parameters in `ScanOptions` must be in the form of string. If you don't think it is necessary, we can also merge it into the builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
